Skip to content

fix: resolve cve-2026-25896#2552

Merged
pepol merged 1 commit intomainfrom
security/fix-cve-2026-25896
Feb 25, 2026
Merged

fix: resolve cve-2026-25896#2552
pepol merged 1 commit intomainfrom
security/fix-cve-2026-25896

Conversation

@pepol
Copy link
Copy Markdown
Member

@pepol pepol commented Feb 24, 2026

Summary by CodeRabbit

  • Chores
    • Updated AWS SDK dependencies across multiple packages to remain compatible with recent SDK releases.
    • Added dependency override entries to enforce consistent resolution of transitive packages and improve build stability and parsing reliability.

Checklist

Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.44%. Comparing base (9972295) to head (454a5a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   43.56%   43.44%   -0.12%     
==========================================
  Files        1030     1030              
  Lines      143745   143745              
  Branches     8941     8931      -10     
==========================================
- Hits        62617    62453     -164     
- Misses      79435    79582     +147     
- Partials     1693     1710      +17     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-84d02bd55c38ccd1ed6a25e28c2c7e31b7fd2cae

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 24, 2026

Walkthrough

Updated @aws-sdk/client-s3 in two subpackages and added pnpm overrides for fast-xml-parser and @aws-sdk/client-sesv2 in the root package.json; no other code or behavioral changes detected. (28 words)

Changes

Cohort / File(s) Summary
AWS SDK Dependency Updates
cdn-server/package.json, controlplane/package.json
Bumped @aws-sdk/client-s3 from ^3.529.1 to ^3.996.0.
Root pnpm overrides
package.json
Added pnpm overrides: fast-xml-parser: >=5.3.6, @aws-sdk/client-sesv2: ^3.996.0; kept existing qs override. Minor JSON entry added.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main purpose of the changeset: resolving a specific CVE security vulnerability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 88: The package.json dependency entry for "fast-xml-parser" currently
uses the unbounded, vulnerable version specifier ">=5.3.5"; update that
specifier to either "^5.3.5" to constrain upgrades to the 5.x line or ">=5.3.6"
to explicitly exclude the vulnerable 5.3.5 release (choose one and replace the
existing ">=5.3.5" value in the package.json dependency for "fast-xml-parser").

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f89b8b and 69f4595.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • cdn-server/package.json
  • controlplane/package.json
  • package.json

Comment thread package.json Outdated
@pepol pepol force-pushed the security/fix-cve-2026-25896 branch from 69f4595 to 297821e Compare February 24, 2026 16:14
@pepol pepol force-pushed the security/fix-cve-2026-25896 branch from 297821e to 454a5a6 Compare February 24, 2026 18:18
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
package.json (1)

90-90: fast-xml-parser: ">=5.3.6" correctly remediates CVE-2026-25896.

CVE-2026-25896 affects all versions from 4.1.3 before 5.3.5; upgrading to 5.3.5 or above resolves the entity encoding bypass (CVSS 9.3). The maintainers released the fix in 5.3.5, and a subsequent commit adding defense-in-depth entity expansion limits was included in a later release. Using >=5.3.6 covers both the primary fix and the defense-in-depth improvement.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 90, Dependency declaration for fast-xml-parser should
explicitly require a secure minimum version; update the package.json entry for
"fast-xml-parser" (the dependency name) to ensure it resolves to at least 5.3.6
(e.g., change the version string to ">=5.3.6" or a fixed minimum like "^5.3.6")
so the CVE-2026-25896 fix and defense-in-depth improvements are pulled in;
verify package-lock.json/yarn.lock is regenerated and included so CI installs
the patched version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 89: The override for "js-yaml": ">=4.1.1" is out-of-scope for the
fast-xml-parser CVE and uses an unbounded range; change the version specifier to
a bounded caret range (e.g., "^4.1.1") to pin to the 4.x line and add a short
comment in package.json (and/or a note in the PR description) stating this was
added specifically to address CVE-2025-64718 (js-yaml 3.14.1/4.1.0) so reviewers
know why this separate security override was included.

---

Duplicate comments:
In `@package.json`:
- Line 90: Dependency declaration for fast-xml-parser should explicitly require
a secure minimum version; update the package.json entry for "fast-xml-parser"
(the dependency name) to ensure it resolves to at least 5.3.6 (e.g., change the
version string to ">=5.3.6" or a fixed minimum like "^5.3.6") so the
CVE-2026-25896 fix and defense-in-depth improvements are pulled in; verify
package-lock.json/yarn.lock is regenerated and included so CI installs the
patched version.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 297821e and 454a5a6.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • cdn-server/package.json
  • controlplane/package.json
  • package.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • controlplane/package.json
  • cdn-server/package.json

Comment thread package.json
@pepol pepol enabled auto-merge (squash) February 24, 2026 19:04
@pepol pepol merged commit f271ff2 into main Feb 25, 2026
51 of 52 checks passed
@pepol pepol deleted the security/fix-cve-2026-25896 branch February 25, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants